Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dev optional dependency #835

Merged
merged 3 commits into from
Aug 21, 2023

Conversation

WilliamJamieson
Copy link
Collaborator

@WilliamJamieson WilliamJamieson commented Aug 16, 2023

This PR adds a dev optional dependency install target for romancal which installs all of the tooling required to build the docs, run the tests, and/or run any of the CI test environments.

Checklist

  • added entry in CHANGES.rst under the corresponding subsection
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

@WilliamJamieson WilliamJamieson requested a review from a team as a code owner August 16, 2023 17:16
@github-actions github-actions bot added documentation Improvements or additions to documentation dependencies Pull requests that update a dependency file labels Aug 16, 2023
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (bfd0070) 76.00% compared to head (1403516) 76.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #835   +/-   ##
=======================================
  Coverage   76.00%   76.00%           
=======================================
  Files          96       96           
  Lines        5788     5788           
=======================================
  Hits         4399     4399           
  Misses       1389     1389           
Flag Coverage Δ *Carryforward flag
nightly 63.92% <ø> (ø) Carriedforward from bfd0070

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This installs all the test and docs dependencies in addition to
the tox an pre-commit tools which are used as part of linting and testing
@zacharyburnett zacharyburnett merged commit a206752 into spacetelescope:main Aug 21, 2023
@WilliamJamieson WilliamJamieson deleted the feature/dev branch August 21, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants